Tong/355 wallet connect component #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supertong
requested review from
totraev,
gbarkhatov,
jrwbabylonlab and
jeremy-babylonlabs
totraev
approved these changes
Dec 9, 2024
gbarkhatov
approved these changes
Dec 11, 2024
supertong
force-pushed
the
tong/355-wallet-connect-component
branch
from
7f25566 to
c8ae9ad
Compare
|
Hey team, this is now ready to have another look:
|
|
It seems like the latest version of the |
|
yep, ill work on this. thanks! |
|
I think there should be space between the elements: https://i.imgur.com/ynJPgbq.png |
jeremy-babylonlabs
force-pushed
the
tong/355-wallet-connect-component
branch
from
fd9ff30 to
5da15bd
Compare
|
@jeremy-babylonlabs please ping in the channel once this PR is ready for review |
jeremy-babylonlabs
force-pushed
the
tong/355-wallet-connect-component
branch
from
5da15bd to
3102cc8
Compare
jeremy-babylonlabs
force-pushed
the
tong/355-wallet-connect-component
branch
from
3102cc8 to
4e3c432
Compare
|
There was a problem hiding this comment.
@supertong and @totraev could you help review this PR as i know nothing about css
|
Hold it. I will review it later |
jeremy-babylonlabs
approved these changes
Dec 23, 2024
jrwbabylonlab
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the UI refinement and I have no idea how to connect the data together. For example, the wallet provider image, addresses and the toggle state are mock data at the moment.